Conversation
omdxp
changed the title
ZibanPirate
requested changes
Dec 31, 2024
web/src/redux/actions/settings.ts
Outdated
| // remove code from url if it's the default language | ||
| if (language.code === Languages[0].code) { | ||
| newPath = newPath.replace(`/${language.code}`, ""); | ||
| newPath = newPath.replace(new RegExp(`^/${language.code}`), "") || "/"; |
Member
There was a problem hiding this comment.
The regex is redundant, lets remove it
/en will always be the first match, and since we're not using replaceAll, this will only replace the first match /en occurrence, which is guaranteed to be the start of the URL because of the if block we're in
omdxp
force-pushed
the
fix/language-switch
branch
from
c13d798 to
82db9f7
Compare
omdxp
force-pushed
the
fix/language-switch
branch
from
82db9f7 to
eb7a694
Compare
ZibanPirate
approved these changes
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #625